exit with underlying exit code #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asobrien
changed the title
brikis98
reviewed
Jan 11, 2017
| @@ -32,7 +34,13 @@ func checkForErrorsAndExit(err error) { | |||
| } else { | |||
| logger.Println(err) | |||
| } | |||
| os.Exit(1) | |||
| // exit with the underlying error code | |||
| var retCode int | |||
There was a problem hiding this comment.
You should default this to 1. Otherwise, if the error is not an ExitError, this will exit with a 0.
| // exit with the underlying error code | ||
| var retCode int | ||
| if exiterr, ok := errors.Unwrap(err).(*exec.ExitError); ok { | ||
| status := exiterr.Sys().(syscall.WaitStatus) |
There was a problem hiding this comment.
This will work on darwin, linux, and windows (all the terragrunt OS's).
It's not completely portable (plan9 prob won't work) but unfortunately there's no portable way to get the exit code. Fortunately, windows and *nix have the same method signatures.
|
LGTM. Thank you! |
|
Just created a new release here: https://github.com/gruntwork-io/terragrunt/releases/tag/v0.8.1. If the build passes, the new binaries should show up in a few minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #37