Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User model choice being ignored in bruvo.msn #17

Closed
zkamvar opened this issue Mar 27, 2015 · 0 comments
Closed

User model choice being ignored in bruvo.msn #17

zkamvar opened this issue Mar 27, 2015 · 0 comments
Assignees

Comments

@zkamvar
Copy link
Member

zkamvar commented Mar 27, 2015

Current workaround solution: calculate bruvo's distance with bruvo.dist() and then feed it into poppr.msn()

Problem: all calls to bruvo.dist() from bruvo.msn() and poppr:::singlepop_msn() do not give the add or loss parameters, thus defaulting to average over genome loss and genome addition models, despite the user choice.

I will fix these in poppr's current devel branch and then make a pull request for @JonahBrooks so that he can incorporate it into his code.

@zkamvar zkamvar self-assigned this Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant