Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla Hold Actions are hidden #15

Open
Tracked by #22
DerZade opened this issue May 31, 2021 · 2 comments
Open
Tracked by #22

Vanilla Hold Actions are hidden #15

DerZade opened this issue May 31, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@DerZade
Copy link
Member

DerZade commented May 31, 2021

This has probably to do with hiding the default action icon 🤔

@DerZade DerZade self-assigned this May 31, 2021
@DerZade DerZade added this to the Public release milestone Jun 2, 2021
@DerZade DerZade added the bug Something isn't working label Jun 10, 2021
@DerZade
Copy link
Member Author

DerZade commented Aug 15, 2021

Sadly this doesn't seem to be easily fixable. :( At least with the current method of handling the default action icon, which is just applying the size via Config within CfgInGameUI. Hold Actions just use addAction so we can't easily differentiate between normal actions and Hold Actions.

Maybe this would be solvable, by applying the size on the fly with scripts and not via config, but to my understanding it is not possible to change attributes of UserActions defined in config, which is true for the majority of actions.

DerZade added a commit that referenced this issue Oct 29, 2021
@DerZade
Copy link
Member Author

DerZade commented Oct 29, 2021

8b15fed seems to fix avoid the issue, but VN has its own implementation of hold-actions. In a perfect world we would fix that as well 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant