Fixed the incompatibility of this module by formatting all functions to ES5. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed them for better use. reformatted the functions into es2015 notation
stahlmanDesign
approved these changes
Mar 20, 2018
|
I forked react-voice-components and merged this PR. I confirm it fixes the problem and it now works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I edited the functions in VoicePlayer.js and VoiceRecognition.js in the lib folder for this module.
The functions are formatted to ES5 syntax, which should make the module available and fix 2 out of the 3 open issues on this module as of March 6, 2018.