Feature/cookie

[guidotripaldi]

No description provided.

[sourcelevel-bot]

There should be no more than 1 consecutive blank lines.

[sourcelevel-bot]

There should be no more than 1 consecutive blank lines.

[sourcelevel-bot]

There should be no more than 1 consecutive blank lines.

[sourcelevel-bot]

Ebert has finished reviewing this Pull Request and has found:

• 7 possible new issues (including those that may have been commented here).
• 7 fixed issues! 🎉

But beware that this branch is 10 commits behind the grych:master branch, and a review of an up to date branch would produce more accurate results.

You can see more details about this review at https://ebertapp.io/github/grych/drab/pulls/144.

[grych]

Again, I see no point to keep Drab.Utils as a separate module, as encode_value actually repeats what is done in Drab.Coder. The ideal API for me would be:

set_cookie cookie, value # no encoding
set_cookie cookie, value, encode: true # default &Drab.Coder.encode/1
set_cookie cookie, value, encode: Drab.Coder.URL # calling Drab.Coder.URL.encode
set_cookie cookie, value, encode: Any.Other.Module # calling Any.Other.Module.encode

cookie cookie # no encoding
cookie cookie, decode: true # default decode
cookie cookie, decode: Drab.Coder.URL 

Let's cut Drab.Utils with Ockham's razor ;)

[guidotripaldi]

Again, I see no point to keep Drab.Utils as a separate module

Was not intentional, I've pushed a bad commit forgetting that it would be update also the pr, sorry

I'm going to remove Drab.Utils

[grych]

Hi @guidotripaldi, don't worry, I understand you don't have time for this. I am going to do a cookie functions myself. Thanks for all the help! You really helped me a lot.