Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSD error 'EventListType': The content model is not determinist #280

Closed
VladimirAlexiev opened this issue May 18, 2021 · 9 comments
Closed
Assignees
Labels
validation Validation of EPCIS data

Comments

@VladimirAlexiev
Copy link
Contributor

I'm not much of an expert on XSD but I tried to validate one of the XML examples (slightly renamed) and got this error:

xmllint --schema ../XSD/EPCglobal-epcis-2_0.xsd Example-TransactionEvents-2020_07_03y.xml
complex type 'EventListType': The content model is not determinist.
WXS schema ../XSD/EPCglobal-epcis-2_0.xsd failed to compile

@CraigRe @RalphTro who's our XSD expert?

Loosely related to #279

@sboeckelmann
Copy link
Collaborator

I am volunteering to look into XSD issues and offer support.

@CraigRe
Copy link
Collaborator

CraigRe commented May 18, 2021

Needs eyeballing and validation checks by @CraigRe @mgh128 @sboeckelmann and @RalphTro .
Make sure to validate all example files against schema prior to CommRev, @VladimirAlexiev recommends using a makefile script to see the source of validation errors at a glance.

@sboeckelmann will also ask @RalphTro if we can run existing (1.x) production data against 2.0 schema, to make sure we are not adding backward incompatibility.

@sboeckelmann
Copy link
Collaborator

@RalphTro, @CraigRe, @mgh128
please check #283

This should be addressing the most pressuring issues with validation.
I will have another look at the XSDs and try to get clearance for checking against existing production data within the next couple of days.

@CraigRe
Copy link
Collaborator

CraigRe commented May 25, 2021

Linked to #283

@VladimirAlexiev
Copy link
Contributor Author

At the Jun 15 telco:

  • there is hope Issues/286 #295 (removal of nested extension envelopes) will alleviate this
  • @shalika-singh (@shalikasingh) said we shouldn't worry too much and should accept non-determinism in the XSD, because that's only a problem in xmllint but not in other commonly used XSD validators. Shalika, please elaborate and correct this if I misstated.

@shalikasingh
Copy link

Hi @VladimirAlexiev,

Its right that xmllint has a limitation of not being able to parse non-deterministic XSD, whereas using API of javax.xml.validation.*, I was able to parse non-deterministic EPCIS XSD and validate events against it.

Fortunately, we don't have to worry about the non-deterministic behavior of XSD anymore as the modified version of XSD submitted by @sboeckelmann as PR: #295 is a deterministic one.

@mgh128
Copy link
Collaborator

mgh128 commented Nov 8, 2021

Thanks to updated XSD from Sven (PR #303 ), I think this issue can now be closed.

@mgh128 mgh128 closed this as completed Nov 8, 2021
@sboeckelmann
Copy link
Collaborator

sboeckelmann commented Nov 9, 2021 via email

@mgh128
Copy link
Collaborator

mgh128 commented Nov 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation Validation of EPCIS data
Projects
None yet
Development

No branches or pull requests

6 participants