add epcis context and ontology #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F-Node-Karlsruhe <christian.fries@eecc.de>
| "rdfs:Class" | ||
| ], | ||
| "rdfs:subClassOf": { | ||
| "@id": "gs1:GS1DataCredential" |
There was a problem hiding this comment.
Question:
Is GS1DataCredential the right choice here?
| "EPCISDocumentCredential": { | ||
| "@id": "gs1:EPCISDocumentCredential" | ||
| }, | ||
| "EPCISEventCredential": { |
There was a problem hiding this comment.
Shall we leave EPCISEventCredential out in VC-Data-Model 1.x?
| "EPCISEventCredential": { | ||
| "@id": "gs1:EPCISEventCredential" | ||
| }, | ||
| "@import": "https://ref.gs1.org/standards/epcis/2.0.0/epcis-context.jsonld" |
There was a problem hiding this comment.
Not necessary if the EPCIS Document/Event carries its own context, as it's supposed to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added EPCISDocumentCredential and EPCISEventCredential types
The second is questionable in VC Data Model 1.x as EPCIS events do not have an id field which could be used as subject.id
Options:
Choosing
should be discussed