Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fine-tune catalog rate limit rule #4630

Closed
FuhuXia opened this issue Feb 26, 2024 · 2 comments
Closed

fine-tune catalog rate limit rule #4630

FuhuXia opened this issue Feb 26, 2024 · 2 comments
Assignees
@FuhuXia
Labels
bug Software defect or bug

Comments

@FuhuXia
Copy link
Member

FuhuXia commented Feb 26, 2024 •
edited
Loading

We have AWS WAF Web ACLs rate limit rule in effect. We haven't noticed a false positive yet, but to make the rule more precise, we want to exclude traffic to web assets (css, js, /favicon.ico ... ) and maptiles, and/or those cached responses, and/or inexpensive api calls, only target for those traffic (/dataset/?page=*, /organization/*, /harvest*) that make a performance impact to catalog app.

Sketch

WAF Rate-limiting criteria allows request header inspection.
@FuhuXia FuhuXia added the bug Software defect or bug label Feb 26, 2024
@FuhuXia
Copy link
Member Author

FuhuXia commented Mar 1, 2024

False positive identified.
https://gsa-tts.slack.com/archives/C2N85536E/p1709303033296899

@FuhuXia FuhuXia self-assigned this Mar 1, 2024
@FuhuXia
Copy link
Member Author

FuhuXia commented Mar 4, 2024

Added customized rules to avoid false positives.

image

@FuhuXia FuhuXia closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FuhuXia FuhuXia

Labels
bug Software defect or bug
Projects
data.gov team board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FuhuXia