Map Entity IDs When Writing Snapshot to World #31
Conversation
|
This looks lovely, but it would be good if we could see it working before merging. We could simply add a smaller cube as a child on top of the player cubes in the examples. What do you think? |
|
Yeah, we should definitely test it, but I think it requires a pretty specific test. I think to run into the issue, we actually need to add a child to an entity, then delete the child in a later frame ( specifically we must use the Actually I think that's isolated enough we can add it as a test case. I'll see if I can put that in a test and verify that it fails before this PR and works after this PR. |
|
Perfect! |
|
There you go! I wrote a test case and discovered a couple bugs which I fixed. |
| // The user can still register any custom types with `register_rollback_type()`. | ||
| r.register::<Parent>(); | ||
| r.register::<Children>(); | ||
| r |
There was a problem hiding this comment.
You'll want to look at this section here. I'm not sure if there's a better place to do this. The comment explains.
|
Awesome work! Thank you so much! |
Resolves #29.
I haven't really tested this yet, but this should fix entity mapping and hierarchy problems.
If this works it'd be good to have some documentation on how this effects types that store entities.
For instance, if you create your own
Inventorycomponent that needs to be synced, you must implement and reflectMapEntitiesfor it, so that it will get the new entity IDs when the snapshots are applied.