Do not compile partials when already compiled #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a page, with partials, was loaded twice, a weird bug appeared: "arguments to path.resolve must be strings".
In
__express.js:10, all the partials' paths were added totemplates, to be compiled (on line 30), even if they were already compiled and stored in the cache.I fixed it with a small
ifstatement inside the for loop. Now it works correctly, at least for me (I didn't test it thoroughly)PS: can you publish as fast as possible to npm? I quite need it for a project of mine :)