Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MARISA_DEBUG_IF in scoped-*.h as opposed to MARISA_THROW_IF #1

Closed
wants to merge 6 commits into from
Closed

Use MARISA_DEBUG_IF in scoped-*.h as opposed to MARISA_THROW_IF #1

wants to merge 6 commits into from

Commits on Sep 17, 2020

  1. Use (~x - 1) instead of -x to suppress compilation errors

    @s-yata
    s-yata committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    26b4626 View commit details
    Browse the repository at this point in the history

  2. Don't include private header files when building tools

    @s-yata
    s-yata committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    6845d73 View commit details
    Browse the repository at this point in the history

  3. Fix AdditionalIncludeDirectories in vs2008

    @s-yata
    s-yata committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    c7a7703 View commit details
    Browse the repository at this point in the history

  4. Add a missing include directory in vs2008

    @s-yata
    s-yata committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    f6d2788 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Add files for Visual Studio 2019

    @s-yata
    s-yata committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    ca018e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Use MARISA_DEBUG_IF in scoped-*.h as opposed to MARISA_THROW_IF 

    These are the only two places that we throw exceptions from header files
in non-debug mode.

With this change, developers can take the marisa library without being
forced to enable exceptions for their whole library / application.

IMO, self-reset does not seem to be fatal enough to throw in production
and MARISA_DEBUG_IF should be enough for us to catch it if we think it
should never happen.
    @tony-mak
    tony-mak committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    88c6d93 View commit details
    Browse the repository at this point in the history