Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a copy button to copy expression #466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

wneel
Copy link

@wneel wneel commented Jul 28, 2022

Hi,

Before I would like to thank you for this super useful website, i use it frequently and one feature that I'm missing is : a copy button !

because each time we want to copy an expression we have to then write / before and /g or /gi or whatever after

So, this PR add a copy expression button :

add_button_to_copy_expression.mp4

336858233118761/add_button_to_copy_expression.mp4)

@napiraz
Copy link

napiraz commented Jul 28, 2022

i would love to see a feature like this !

@wneel wneel closed this Dec 21, 2022
@wneel wneel reopened this Dec 21, 2022
@gskinner
Copy link
Owner

gskinner commented Dec 21, 2022

Thanks for the PR! Apologies for the delay in responding.

A couple notes:

  1. We have fairly limited space in those headers when running at minimum width, so I'd reduce it to just an icon, or maybe an icon + "Copy".
  2. If this is going to be added, I think it needs to be in a language agnostic way. This is actually part of what prevented me adding this before. Here's a sketch of one way I could see that working — it's a little bit cludgy, but workable. Totally open to other ideas too.

image

@wneel
Copy link
Author

wneel commented Dec 23, 2022

Thank you for the reply !

I totally understand the the need to suggest more specific options for every uses cases and languages, I am currently on a project but I edit the PR asap and I'll make those change !

And of course I understand the size constraints and I will take them into account when submitting an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants