Issue/167 #180
Issue/167 #180
Conversation
|
Deploy preview for sg-storybook ready! Built with commit fc669bb |
|
Deploy preview for sg-orbit ready! Built with commit fc669bb |
|
|
||
| const textAreaRef = useRef(); | ||
|
|
||
| useImperativeHandle(forwardedRef, () => getTextAreaElement(textAreaRef)); |
There was a problem hiding this comment.
you don't have to use useImperativeHandle in this case, simply pass forwardRef to Ref instead of creating a proxy ref.
<Ref innerRef={forwardRef} ...
|
Should we support We already have |
rows is a default attribute of textarea |
This is something to discuss with designers, I think it doesn't make sense height wise, but font sizes should match the input's font size, a different line-height might be a good idea too. |
We should follow the same padding, font-size, as same size input, I will adjust before closing this PR. |
|
A Jest test is failing, this seems to be the same issue as this: testing-library/jest-dom#53 |
Yes, we already use the user-event library to mitigates those problems. I wonder if this is the same problem you're experiencing though since the component you are testing is explicitly focusing on a dom element, this is not the same as triggering a click event and expecting the target element to have focus. |
| <Preview> | ||
| <Story name="size"> | ||
| <div className="flex flex-row items-end items-space-between"> | ||
| <div className="flex-auto"> |
There was a problem hiding this comment.
Do you need flex-auto here?
In fact, I added it for the date picker but I don't understand why we need flex-auto.
There was a problem hiding this comment.
See flex auto explanation on MDN : The item is sized according to its width and height properties, but grows to absorb any extra free space in the flex container, this is the equivalent of "flex: 1 1 auto"
soit flex grow 1 shrink1 basis auto
|
Like an input, IMO a textarea shouldn't be fluid by default? It should support a |
Issue:
#167 #181 #198 #200
TextArea was not supported in Orbit.
What I did
Created a component TextArea which is a HOC of Semantic UI TextArea component. This component supports success, transparent, error, autofocusdelay
How to test
Is this testable with Jest or Chromatic screenshots?
Both.
Does this need an update to the documentation?
Yes, documentation has been created.