Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextField, PasswordField and SearchField #280

Merged
merged 41 commits into from
Jun 6, 2024
Merged

Conversation

alexasselin008
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented May 22, 2024

⚠️ No Changeset found

Latest commit: 067989e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented May 22, 2024

Deploy Preview for wl-hopper ready!

Name Link
🔨 Latest commit 067989e
🔍 Latest deploy log https://app.netlify.com/sites/wl-hopper/deploys/6662073ddc951100086e1247
😎 Deploy Preview https://deploy-preview-280--wl-hopper.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented May 22, 2024

View Storybook

@alexasselin008 alexasselin008 changed the title [Self-reviwing] Add TextField, PasswordField and SearchField Add TextField, PasswordField and SearchField May 24, 2024
@alexasselin008
Copy link
Member Author

alexasselin008 commented May 27, 2024

one thing I've noticed with the TextField is that if you click the edges, it won't focus the text field to be able to type.
I'm not sure if it's a big deal or if we want it to do that, but something to think about.
Similar to when you had the hover issue

@alexasselin008 alexasselin008 merged commit 4a68e31 into main Jun 6, 2024
8 checks passed
@alexasselin008 alexasselin008 deleted the feature/inputs branch June 6, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants