Add end-to-end-tests #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also discovered what I think could be a bug with Chai (chaijs/chai#270) which is why I updated mocha, chai, and grunt-mocha-phantomjs. |
|
@Inviz can you say whether you think these specs are worth adding? |
|
I think it wouldn't hurt to have them. I'd love to in fact. Didnt see this before. Though yeah, it uses chains, so need to upgrade the syntax |
|
@Inviz - I tried adding the changes in Can you take a quick look at the file and see if they're still valid? |
| "[large-message-width]": 480 | ||
| done() | ||
| catch error | ||
| done error |
There was a problem hiding this comment.
On my new branch, this one times out after 2000ms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was created to check whether some issues I ran into while using GSS were legitimate bugs. Of the specs I added, all but one pass.
The spec I added for virtuals demonstrates the error reported at gss/vfl-compiler#8
cc @d4tocchini