Fix 2d with arithmetic #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
January 27, 2015 13:46
cbchouinard
assigned d4tocchini, paulyoung and cbchouinard and unassigned d4tocchini and paulyoung
| # for item in properties | ||
| # expression = expression.slice() | ||
| # expression[2] = item | ||
| # expressions.push expression |
cbchouinard
added a commit
that referenced
this pull request
Jan 30, 2015
Add support for nested arithmetic operations on 2D operations and support 2D expansion for 2D variable names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2D properties didn't support arithmetic operations. I've extracted the 2D unpacking from the grammar to a new module working on the AST. This pull request will provide full support for arithmetic operation on 2D properties.