Escape single quote formula field #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Dalias <kevin@dalias.me>
Signed-off-by: Kevin Dalias <kevin@dalias.me>
Signed-off-by: Kevin Dalias <kevin@dalias.me>
Signed-off-by: Kevin Dalias <kevin@dalias.me>
Signed-off-by: Kevin Dalias <kevin@dalias.me>
|
Any chance we can get this merged and published? |
|
@cancan101 I am merging this now but not sure when I will be able to cut a release |
|
@cancan101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling to escape single quotes in formula field values, if not already escaped, as well as associated test cases. This closes the original pull request (#111) per our conversation in March. I realize it took me a while to get to it... thanks for your patience.
Let me know what you think - feedback welcome!