Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Timeout in Requests #64

Closed
johruss opened this issue Dec 25, 2019 · 1 comment · Fixed by #76
Closed

Configurable Timeout in Requests #64

johruss opened this issue Dec 25, 2019 · 1 comment · Fixed by #76

Comments

@johruss
Copy link

johruss commented Dec 25, 2019

Hello,

I have an unsteady internet connection, and I had to add timeout=(3,10) to line 170 to get it to kick up and not get paralysed.
If you read https://realpython.com/python-requests/#timeouts, you will say they say :
"When you make an inline request to an external service, your system will need to wait upon the response before moving on. If your application waits too long for that response, requests to your service could back up, your user experience could suffer, or your background jobs could hang.

By default, requests will wait indefinitely on the response, so you should almost always specify a timeout duration to prevent these things from happening. To set the request’s timeout, use the timeout parameter. timeout can be an integer or float representing the number of seconds to wait on a response before timing out:"

Please make this standard, it will save a lot of time to others.

@gtalarico
Copy link
Owner

Happy to merge a PR

@gtalarico gtalarico changed the title Timeout in Requests Configurable Timeout in Requests Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants