Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ristretto255: replace backend with filippo.io/edwards25519 #41

Merged
merged 1 commit into from
Sep 30, 2021
Merged

ristretto255: replace backend with filippo.io/edwards25519 #41

merged 1 commit into from
Sep 30, 2021

Conversation

FiloSottile
Copy link
Collaborator

Only one API change over #39, which is good because Elements should not be compared with == or used as map keys.

$ gorelease -base=ee84ce73ae03b6a2121400fb3c61c50540b3dfbb
github.com/gtank/ristretto255
-----------------------------
Incompatible changes:
- Element: old is comparable, new is not

@FiloSottile FiloSottile requested a review from gtank June 5, 2021 11:14
@adr1anh adr1anh mentioned this pull request Jun 6, 2021
Merged
gtank
gtank approved these changes Sep 30, 2021
View reviewed changes
Copy link
Owner

@gtank gtank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, looks good

@FiloSottile FiloSottile merged commit 6bb3979 into master Sep 30, 2021
@FiloSottile FiloSottile deleted the filippo/edwards25519backend branch September 30, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtank gtank gtank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FiloSottile @gtank