Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have $ without currency? #17

Closed
jamie9090 opened this issue Dec 9, 2022 · 3 comments
Closed

Have $ without currency? #17

jamie9090 opened this issue Dec 9, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request release Completed. Will be in next release

Comments

@jamie9090
Copy link

Hey there - love this.

Would appreciate being able to disable the conversion from "$" to USD in calculations

Or to have support for a different default currency

From my end, I use AUD :)

@gtg922r
Copy link
Owner

gtg922r commented Dec 9, 2022

Yeah this is definitely on the roadmap, I'll try to do this next.

Currently, the underlying library necessitates a conversion to something other than the $ symbol so my plan is simply to allow users to define what the currency associated with $ is.

@gtg922r gtg922r added enhancement New feature or request roadmap Planned feature on the roadmap labels Dec 9, 2022
@jamie9090
Copy link
Author

jamie9090 commented Dec 9, 2022 via email

gtg922r added a commit that referenced this issue Dec 13, 2022
- Added two options to settings which allow association of specific ISO currency code with `$` and `¥`
- Due to limitations in mathjs will need to reload obsidian to take effect
gtg922r added a commit that referenced this issue Dec 13, 2022
@gtg922r
Copy link
Owner

gtg922r commented Dec 13, 2022

Initial support added and ready for testing. Should be able to release by end of week. Will be able to select all ISO currencies that use $, include USD, AUD, CAD, NZD, MXN, etc

Screenshot 2022-12-13 at 1 54 31 AM

Note, for technical reasons within the mathjs math engine that Numerals uses, I can't allow use of $<amount> without mapping it to a currency. I'm essentially creating a new physical unit, and the convention for units is they trail the number they apply to (e.g. 4km or 10 seconds).

@gtg922r gtg922r added in-progress Currently in development release Completed. Will be in next release documentation Improvements or additions to documentation and removed in-progress Currently in development roadmap Planned feature on the roadmap labels Dec 13, 2022
@gtg922r gtg922r closed this as completed Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request release Completed. Will be in next release
Projects
None yet
Development

No branches or pull requests

2 participants