Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Youtube changes broke current Pytube version #23

Closed
1 of 2 tasks
gth828r opened this issue Apr 19, 2022 · 3 comments
Closed
1 of 2 tasks

Youtube changes broke current Pytube version #23

gth828r opened this issue Apr 19, 2022 · 3 comments
Assignees
@gth828r
Labels
bug Something isn't working

Comments

@gth828r
Copy link
Owner

gth828r commented Apr 19, 2022 •
edited
Loading

It looks like pytube is broken again due to changes made on the Youtube side. The fix is allegedly queued up at pytube/pytube#1282 but it still needs to be merged. Once a new release is cut, update our dependency version.
@gth828r gth828r added the bug Something isn't working label Apr 19, 2022
@gth828r gth828r added this to the v0.1.1 milestone Apr 19, 2022
@gth828r gth828r self-assigned this Apr 19, 2022
@gth828r gth828r changed the title Pytube is broken again Youtube changes broke current Pytube version Apr 19, 2022
@gth828r gth828r mentioned this issue Apr 19, 2022
Closed
@gth828r
Copy link
Owner Author

gth828r commented Apr 28, 2022

Well, I've taken care of all of the other issues on this milestone, but the merge request for the pytube fix has not been merged yet, nor has a release been cut. I was originally planning on waiting for the new release, but I may need to take action to pull from a temporary source with these changes sooner.

gth828r added a commit that referenced this issue Apr 30, 2022
@gth828r
Temporarily fix pytube
491e747 
There is a fix queued up on the PR list for pytube, but it hasn't been
accepted yet. Cut a temporary release with that fix, and pull that
version for now. We will switch back to the new official release once it
is ready in #23.

Addresses #32
@gth828r gth828r removed this from the v0.1.1 milestone Apr 30, 2022
@gth828r
Copy link
Owner Author

gth828r commented May 9, 2022

The PR was merged and a new pip version of pytube was cut. We should update our fork and switch back to the pip version. If another issue like this comes up, we can always move back to the fork.

gth828r added a commit that referenced this issue May 14, 2022
@gth828r
Switch back to mainline pytube
ef8af28 
The pytube 12.1.0 fixes recent issues. Switch back from our temporary
fork-based version to the most recent official pytube pip release.

Addresses #23
@gth828r
Copy link
Owner Author

gth828r commented May 14, 2022

This has been fixed, and we have updated to the newest official pytube pip package.

@gth828r gth828r closed this as completed May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gth828r gth828r

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gth828r