Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define some initial unit tests #5

Closed
gth828r opened this issue Feb 7, 2022 · 3 comments
Closed

Define some initial unit tests #5

gth828r opened this issue Feb 7, 2022 · 3 comments
Assignees
@gth828r
Labels
ci Continuous Integration task enhancement New feature or request
Milestone
v0.1.1

Comments

@gth828r
Copy link
Owner

gth828r commented Feb 7, 2022

We should start creating some very basic unit tests to at least create the structure and create some templates for more unit tests as time permits. The ActionParser methods seem like a good thing to test at this time.
@gth828r gth828r added the enhancement New feature or request label Feb 7, 2022
@gth828r gth828r added this to the v0.1.1 milestone Feb 7, 2022
@gth828r gth828r self-assigned this Feb 7, 2022
@gth828r gth828r mentioned this issue Feb 7, 2022
Closed
@gth828r gth828r added the ci Continuous Integration task label Mar 13, 2022
@gth828r
Copy link
Owner Author

gth828r commented Mar 13, 2022

We should also run these tests under CI.

@gth828r
Copy link
Owner Author

gth828r commented Apr 20, 2022

I am going to split out running under CI into a different issue. The initial adding of unit tests is already a massive change anyway.

@gth828r gth828r mentioned this issue Apr 20, 2022
Closed
gth828r added a commit that referenced this issue Apr 20, 2022
@gth828r
Add initial unit tests
9110314 
 * Add unit tests for all package modules
   * Parser coverage is currently incomplete, but it is reasonable
   * Runner coverage is also incomplete, but most of the untested code
     is related to writing to disk
   * THe merging process in the runner module should have tests added
 * Ignore some untested lines which only call third party code which
   may be slow (using pragma no cover markings)
 * Update dev package to include coverage and pytest
 * Ignore warnings generated by importing spleeter in tests
 * Ignore .coverage file

Addresses #5
@gth828r
Copy link
Owner Author

gth828r commented Apr 20, 2022

This is done. We don't have full coverage, but so far it is pretty good. Many of the lines which we don't have covered will simply need to be mocked up anyway. With that said, there is still room for improvement.

@gth828r gth828r closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gth828r gth828r

Labels
ci Continuous Integration task enhancement New feature or request
Projects
None yet
Milestone
v0.1.1
Development

No branches or pull requests
1 participant
@gth828r