Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signals with non refcounted Records #240

Closed
EPashkin opened this issue Apr 21, 2016 · 1 comment
Closed

Signals with non refcounted Records #240

EPashkin opened this issue Apr 21, 2016 · 1 comment

Comments

@EPashkin
Copy link
Member

EPashkin commented Apr 21, 2016 •
edited

Some signals have record parameters that used with RefMode::ByRefMut (direct and boxed records),
so closure type looks like Fn(&CellRendererCombo, &str, &mut TreeIter) + 'static but IMHO mutable really unneeded as it in parameter.
Ex. CellArea: apply-attributes
CellRendererCombo: changed
EntryCompletion: cursor-on-match
Currently I hide mut in codegen\trampoline::func_parameter.
This is normal?
cc @gkoz
Part of #199
@EPashkin EPashkin mentioned this issue Apr 21, 2016
Closed
@EPashkin
Copy link
Member Author

Seems fixed by #293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EPashkin