Greatly improve clone! proc macro error output
#963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jf2048
requested changes
Feb 6, 2023
GuillaumeGomez
force-pushed
the
clone-proc-macro
branch
from
2dfe5dc
to
a9edb11
Compare
|
Updated! |
GuillaumeGomez
force-pushed
the
clone-proc-macro
branch
from
a9edb11
to
8f71b27
Compare
GuillaumeGomez
force-pushed
the
clone-proc-macro
branch
from
8f71b27
to
3c7f5e5
Compare
GuillaumeGomez
force-pushed
the
clone-proc-macro
branch
from
3c7f5e5
to
a826b35
Compare
sdroege
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #956.
What is it this PR doing? Instead of using
panic!whenever we encounter an invalid input, it generates acompile_error!call with the span of the token which created the issue to trick the compiler into given the location we want.Unfortunately, the spans are limited with stable rustc so I can't use
Span::jointo make it look better in some cases, but I think it remains a great improvement nonetheless.