Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Popover constrain API is not exposed #426

Closed
Susurrus opened this issue Jan 18, 2017 · 7 comments
Closed

Popover constrain API is not exposed #426

Susurrus opened this issue Jan 18, 2017 · 7 comments

Comments

@Susurrus
Copy link
Contributor

The Popover class is missing set/get_constrain_to and the related PopoverConstraint. This code is commented out in the gir-generated files, but I'm not certain why. But re-running Gir locally within this repo doesn't regenerate any code for versions newer than 3.12. Is this because the Gtk.gir file needs to be updated for the Popover class?

@EPashkin
Copy link
Member

In line //fn get_constrain_to(&self) -> /*Ignored*/PopoverConstraint; /*Ignored*/ means that PopoverConstraint don't generated. Normally you need add "Gtk.PopoverConstraint", to generate = [ array in config.
Don't understand why you don't get 3.14++ versions by generate (may be your installed gtk too old)?

@Susurrus
Copy link
Contributor Author

Okay, I added the missing type. I definitely have Gtk3.20 on this machine (Runing Fedora 25). Do you know how Gir decides what version to generate for? I don't know where I'd even check what version it's trying to generate files for.

@EPashkin
Copy link
Member

If I don't forgot anything, for gir just uses .gir files and add all versions from it.

@Susurrus
Copy link
Contributor Author

Susurrus commented Jan 18, 2017

When running make gir after adding the PopoverConstraint type to Gir.toml I got WARN:gir::config::gobjects: Configured object Gtk.PopoverConstraint missing from the library. But I don't actually understand what that means. In the Gtk-3.0.gir file the PopoverConstraint value is defined there.

@EPashkin
Copy link
Member

@Susurrus, can you clone gtk to new place and do make in it? May be your gir \ gir-files submodules gone wrong.

@Susurrus
Copy link
Contributor Author

Indeed, a git clean in the submodules and a submodule update fixed things. See the PR I just made that fixes this. Thanks for your help!

@Susurrus
Copy link
Contributor Author

I'm closing this in light of #427.

alex179ohm pushed a commit to alex179ohm/gtk that referenced this issue Oct 21, 2019
Implement Default::default() for types with an empty constructor
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants