setup on fedora required code changes

[jpercyasnet]

I am running on fedora 33 and installed rust and gtk4-devel using dnf. When trying to get rust to compile I had to add
[dependencies]
gtk4 = { git = "https://github.com/gtk-rs/gtk4.git" }
to the Cargo.toml (just using gtk = .. did not work)
Also I compile the basic.rs code in the example, but any reference to gtk, I had to change to gtk4.
Is this an issue?

[sdroege]

Can you describe what exactly you were compiling and how? gtk4 = { git = "https://github.com/gtk-rs/gtk4-rs.git" } would be correct for a crate outside this repository.

[jpercyasnet]

this is the main.rs file:

//! # Basic Sample
//!
//! This sample demonstrates how to create a toplevel `window`, set its title, size and
//! position, how to add a `button` to this `window` and how to connect signals with
//! actions.
use gtk4::prelude::*;

use std::env::args;

fn build_ui(application: &gtk4::Application) {
    let window = gtk4::ApplicationWindow::new(application);

    window.set_title(Some("First GTK Program"));
    window.set_default_size(350, 70);

    let button = gtk4::Button::with_label("Click me!");

    window.set_child(Some(&button));

    window.show();
}

fn main() {
    let application =
        gtk4::Application::new(Some("com.github.gtk-rs.examples.basic"), Default::default())
            .expect("Initialization failed...");

    application.connect_activate(|app| {
        build_ui(app);
    });

    application.run(&args().collect::<Vec<_>>());
}

and this is the Cargo.toml file:

[package]
name = "basictest"
version = "0.1.0"
authors = ["jp"]
edition = "2018"

[dependencies]
gtk4 = { git = "https://github.com/gtk-rs/gtk4.git" }

just did the normal cargo new basictest and executed cargo run in the new directory.

[sdroege]

Yes that looks correct but you should better use https://github.com/gtk-rs/gtk4-rs.git instead of https://github.com/gtk-rs/gtk4.git. You're currently using the old repository.

What exactly is the problem though?

[bilelmoussaoui]

Yes that looks correct but you should better use https://github.com/gtk-rs/gtk4-rs.git instead of https://github.com/gtk-rs/gtk4.git. You're currently using the old repository.

We should archive all the old gtk4 repositories as they are just very confusing and are not useful any more.
cc @GuillaumeGomez

[GuillaumeGomez]

Done!

[bilelmoussaoui]

Thank you !