Why does Layout::set_text need a length argument?

[johncf]

Can't the length be calculated within Layout::set_text?

[GuillaumeGomez]

It's part of the things we need to improve. However I was certain that we removed the next argument if it was an integer and the current one was a string. Did I miss something @EPashkin?

[mjkillough]

I can't see any code in GIR that would do that, but I might be looking for the wrong thing.

I can see that CssProvider.load_from_data() is implemented manually in order to hide its length parameter. Would it be appropriate to do something similar here, or is a generic solution in GIR preferable? I'd be happy to have a go at fixing this in either case.

[EPashkin]

It still under construction gtk-rs/gir#376
I think we accept manual version until issue fixed.

[mjkillough]

I see gtk-rs/gir#376 is in progress, so I think it's fine to wait for it to be done automatically.

[sdroege]

This is not covered unfortunately because the array-length annotation is missing in Pango. Someone should file a bug in Bugzilla to get this added, or I'll do it if nobody else is faster.

[EPashkin]

Maybe we need add config override for array-length?

[sdroege]

That would make sense (and is relatively simple), yes. Nonetheless all these things should be reported to the respective C libraries.

[sdroege]

https://bugzilla.gnome.org/show_bug.cgi?id=784021
IMHO we should just patch the Pango .gir file instead of adding configuration. Configuration only makes sense for things that can't be expressed by the .gir file.

[EPashkin]

Currently we strong against patching .gir files as it will be replaced by next update.
Or we need patching mechanism that works good with xml files.

[sdroege]

Next upstream release would ideally have these changes so no patching would be needed after an update.

[EPashkin]

Maybe but I don't want look change in big xml and think, fixed it actually or not :(

[sdroege]

The changes between versions are not actually very big usually, unless you skip many major versions. When doing GStreamer releases, I usually go through the diff of the .gir files and it was a manageable task so far. Usually there are not many changes/additions to already existing types.

Problem I see with a configuration is that it "makes lazy", and then the annotations are never fixed in the C libraries and every binding ships its own configuration around for these bugs.

[sdroege]

See gtk-rs/gir#387 (comment) . Needs manual bindings for these functions that take a string+length, or return a string+length

[mjkillough]

🎉 It looks like this is fixed in the latest pango release: LayoutExt::set_text(&str)

[GuillaumeGomez]

Then let's close it. :)