Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to d 2.059, use strings instead of char[], bugfixes #6

Closed
wants to merge 11 commits into from

Conversation

martindemello
Copy link
Contributor

I've gone through and fixed all the deprecated/removed standard library calls that were throwing up warnings and/or errors with d2.059 and phobos. Also, I've replaced char[] with string throughout. Sorry about the huge wodge of code, but there was really no way to do this in small increments.

Plus some bugfixes:

  • The fix-utf code was generating spurious invalid utf8 events, and segfaulting, due to iterating over the html file with a char rather than a dchar
  • the "guint : 32; //comment" parser was not stripping off the ; onwards before converting to int

@MikeWey
Copy link
Member

MikeWey commented May 10, 2012

There are a few int/size_t errors on 64 bits.

@martindemello
Copy link
Contributor Author

okay, i'll get a 64 bit vm set up and take a look

@martindemello
Copy link
Contributor Author

compiles cleanly on both 32 and 64 bit now, and the generated output looks fine.

@MikeWey
Copy link
Member

MikeWey commented May 12, 2012

Why did you close the pull request?

There is one problem with the output in that some functions have changed there return type from string to char, i'll add an comment on the offending line in the commit.

Could you rebase the pull request so that the fixes are part of the initial commit?

@martindemello
Copy link
Contributor Author

okay, i think i misunderstood what "close pull request" did. i was trying to stop new pushes to master from being appended to this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants