Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32 pecl-cairo master tests fail with cairo 1.8 #16

Closed
medic123de opened this issue Feb 7, 2015 · 5 comments
Closed

32 pecl-cairo master tests fail with cairo 1.8 #16

medic123de opened this issue Feb 7, 2015 · 5 comments

Comments

@medic123de
Copy link

"Oh RedHat, you make life angry!"

Yes, they do!
"old software is stable, and stable software is good."
Therefore: The older, the more stable. like Windows XP .)

CentOS release 6.5 (Final)
 cairo                                       x86_64                                 1.8.8-3.1.el6                                     
 cairo-devel                                 x86_64                                 1.8.8-3.1.el6                                   

=====================================================================
PHP         : /usr/bin/php 
PHP_SAPI    : cli
PHP_VERSION : 5.4.30
ZEND_VERSION: 2.4.0
PHP_OS      : Linux - Linux local@host 2.6.32-504.el6.x86_64 #1 SMP Wed Oct 15 04:27:16 UTC 2014 x86_64
INI actual  : /root/git/cairo.medic/tmp-php.ini
More .INIs  :  
CWD         : /root/git/cairo.medic
Extra dirs  : 
VALGRIND    : Not used
=====================================================================
TIME START 2015-02-07 12:49:25

=====================================================================
TIME END 2015-02-07 12:50:37

=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped    :    0
Exts tested     :   30
---------------------------------------------------------------------

Number of tests :  447               440
Tests skipped   :    7 (  1.6%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :   32 (  7.2%) (  7.3%)
Expected fail   :    0 (  0.0%) (  0.0%)
Tests passed    :  408 ( 91.3%) ( 92.7%)
---------------------------------------------------------------------
Time taken      :   72 seconds
=====================================================================

=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
Cairo::statusToString() method [tests/Cairo/statusToString.phpt]
cairo_text_path() function [tests/CairoContext/Paths/cairo_text_path.phpt]
CairoContext->textPath() method [tests/CairoContext/Paths/textPath.phpt]
cairo_get_scaled_font() function [tests/CairoContext/Text/cairo_get_scaled_font.phpt]
cairo_set_scaled_font() function [tests/CairoContext/Text/cairo_set_scaled_font.phpt]
CairoContext->setScaledFont() method [tests/CairoContext/Text/getScaledFont.phpt]
CairoContext->setScaledFont() method [tests/CairoContext/Text/setScaledFont.phpt]
cairo_restore function [tests/CairoContext/cairo_restore.phpt]
CairoContext->restore() method [tests/CairoContext/restore.phpt]
new CairoScaledFont [ __construct() method ] [tests/CairoScaledFont/__construct.phpt]
cairo_scaled_font_create() function [tests/CairoScaledFont/cairo_scaled_font_create.phpt]
cairo_scaled_font_extents() function [tests/CairoScaledFont/cairo_scaled_font_extents.phpt]
cairo_scaled_font_get_ctm() function [tests/CairoScaledFont/cairo_scaled_font_get_ctm.phpt]
cairo_scaled_font_get_font_face() function [tests/CairoScaledFont/cairo_scaled_font_get_font_face.phpt]
cairo_scaled_font_get_font_matrix() function [tests/CairoScaledFont/cairo_scaled_font_get_font_matrix.phpt]
cairo_scaled_font_get_font_options() function [tests/CairoScaledFont/cairo_scaled_font_get_font_options.phpt]
cairo_scaled_font_get_scale_matrix() function [tests/CairoScaledFont/cairo_scaled_font_get_scale_matrix.phpt]
cairo_scaled_font_get_type() function [tests/CairoScaledFont/cairo_scaled_font_get_type.phpt]
cairo_scaled_font_status() function [tests/CairoScaledFont/cairo_scaled_font_status.phpt]
cairo_scaled_font_text_extents() function [tests/CairoScaledFont/cairo_scaled_font_text_extents.phpt]
CairoScaledFont->extents() method [tests/CairoScaledFont/extents.phpt]
CairoScaledFont->getCtm() method [tests/CairoScaledFont/getCtm.phpt]
CairoScaledFont->getFontFace() method [tests/CairoScaledFont/getFontFace.phpt]
CairoScaledFont->getFontMatrix() method [tests/CairoScaledFont/getFontMatrix.phpt]
CairoScaledFont->getFontOptions() method [tests/CairoScaledFont/getFontOptions.phpt]
CairoScaledFont->getScaleMatrix() method [tests/CairoScaledFont/getScaleMatrix.phpt]
CairoScaledFont->getType() method [tests/CairoScaledFont/getType.phpt]
CairoScaledFont->status() method [tests/CairoScaledFont/status.phpt]
CairoScaledFont->textExtents() method [tests/CairoScaledFont/textExtents.phpt]
new CairoSubSurface [ __construct method ] [tests/CairoSurface/CairoSubSurface/__construct.phpt]
cairo_surface_create_for_rectangle () function [tests/CairoSurface/cairo_surface_create_for_rectangle.phpt]
cairo_status_to_string function [tests/cairo_status_to_string.phpt]
=====================================================================
@medic123de
Copy link
Author

@auroraeosrose
I should add: it works nevertheless.. maybe you can exclude the tests/functions if underlying cairo does not support it ?
would that be possible/OK to you ?

@auroraeosrose
Copy link
Member

First of all - what is the actual failure in the test files? there should be .out and .diff files so you can see the actual problem

So 1.8 is the supported version from redhat? all the 1.10 and higher stuff should be in ifdefs

@medic123de
Copy link
Author

From my memory, it's mostly "function undefined".

ifdef is a brilliant idea.
If OK for you, i'd check the function reference of cairo, set all tests to functions not implemented into according ifdef's and make test again, not expecting errors.
Posting them here if there any errors left.

Our Developers told me today, what they use from your extension works like a charm, so it's not exactly "incompatible" with 1.8.8

@medic123de medic123de changed the title pecl-cairo master not compatible to cairo 1.8 32vpecl-cairo master tests fail with cairo 1.8 Feb 12, 2015
@medic123de medic123de changed the title 32vpecl-cairo master tests fail with cairo 1.8 32 pecl-cairo master tests fail with cairo 1.8 Feb 12, 2015
@auroraeosrose
Copy link
Member

There's other stuff already ifdef'd out by version, just need to find the version those things were introduced in :)

@auroraeosrose
Copy link
Member

libcairo 1.10 is now 6 years old... and since I don't have a good list of symbols introduced and
we know it works perfectly with 1.10 and higher, I'm explicitly upping the version requirement

May not be the fix you want, but now config will tell you when your version is too old instead of hitting missing symbols

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants