Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix epsilon composition #14

Merged
merged 8 commits into from
Nov 30, 2021
Merged

Fix epsilon composition #14

merged 8 commits into from
Nov 30, 2021

Conversation

awni
Copy link
Contributor

@awni awni commented Nov 22, 2021

Fix bug with epsilon composition.

Tests

Running tests...
Test project /Users/awni/repos/gtn/build
Start 1: autograd_test
1/8 Test #1: autograd_test .................... Passed 0.87 sec
Start 2: creations_test
2/8 Test #2: creations_test ................... Passed 0.37 sec
Start 3: criterion_test
3/8 Test #3: criterion_test ................... Passed 0.57 sec
Start 4: functions_test
4/8 Test #4: functions_test ................... Passed 0.86 sec
Start 5: parallel_test
5/8 Test #5: parallel_test .................... Passed 0.81 sec
Start 6: graph_test
6/8 Test #6: graph_test ....................... Passed 0.44 sec
Start 7: utils_test
7/8 Test #7: utils_test ....................... Passed 0.33 sec
Start 8: rand_test
8/8 Test #8: rand_test ........................ Passed 0.50 sec

100% tests passed, 0 tests failed out of 8

Total Test time (real) = 4.74 sec

Benchmarks

TLDR not a huge impact, negligible for CTC.

Before fix

Timing composeForward ... 142.12 msec
Timing composeBackward ... 0.79 msec
Timing composeForwardSorted ... 9.53 msec
Timing ctcLoss ... 124.37 msec
Timing ctcGrad ... 21.44 msec
Timing ngramCtcLoss ... 5.47 msec
Timing ngramCtcGrad ... 0.61 msec
Timing ctcBatched ... 210.01 msec

After fix

Timing composeForward ... 144.14 msec
Timing composeBackward ... 0.8 msec
Timing composeForwardSorted ... 10.19 msec
Timing ctcLoss ... 131.27 msec
Timing ctcGrad ... 21.73 msec
Timing ngramCtcLoss ... 6.19 msec
Timing ngramCtcGrad ... 0.61 msec
Timing ctcBatched ... 218.7 msec

@awni awni requested a review from shubho November 22, 2021 20:36
@awni awni merged commit e6f1caf into gtn-org:master Nov 30, 2021
@awni awni deleted the epsilon_compose branch December 28, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant