Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser rebase #112

Merged
merged 4 commits into from
Sep 28, 2022
Merged

Parser rebase #112

merged 4 commits into from
Sep 28, 2022

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Sep 28, 2022

Signed-off-by: pxp928 parth.psu@gmail.com

Rebase the parser to be more pluggable for different document types

Closes: #83

Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 pxp928 mentioned this pull request Sep 28, 2022
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, lgtm otherwise

pkg/ingestor/parser/common/types.go Outdated Show resolved Hide resolved
Signed-off-by: pxp928 <parth.psu@gmail.com>
Copy link
Collaborator

@mlieberman85 mlieberman85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 9e26407 into guacsec:main Sep 28, 2022
mrizzi added a commit to mrizzi/guac that referenced this pull request Aug 6, 2024
Signed-off-by: mrizzi <mrizzi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task: [ingestor] break parser into plugin model
3 participants