Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pkg equals bulk ingestion and arango updates #1239

Merged
merged 7 commits into from Sep 8, 2023
Merged

Feature/pkg equals bulk ingestion and arango updates #1239

merged 7 commits into from Sep 8, 2023

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Sep 8, 2023

Description of the PR

  • bulk ingestion for pkg Equal
  • update resolver checks and add missing unit tests
  • update inmem backend with unit tests
  • update arango backend with unit tests

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928
update generated code
cd9459d 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
update bulk assembler and rename ingest hashEqauls
a2353ab 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
udpate resolver with unit tests
cd621ae 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add to backend interface
6e2a883 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
update inmem backend with tests
348556c 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
fix inmem unit tests
d322935 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
update inmem pkgEqual
9805676 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
Copy link
Collaborator Author

pxp928 commented Sep 8, 2023 •
edited

@mrizzi FYI added bulk ingestion for pkgEquals

@mrizzi
Copy link
Collaborator

mrizzi commented Sep 8, 2023

@mrizzi FYI added bulk ingestion for pkgEquals

Once merged, I'll take care of implementing it for the Ent backend.

@pxp928 pxp928 requested a review from lumjjb September 8, 2023 14:35
@kodiakhq kodiakhq bot merged commit 70774ce into guacsec:main Sep 8, 2023
9 checks passed
@mrizzi mrizzi mentioned this pull request Sep 8, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pxp928 @mrizzi @mihaimaruseac @jeffmendoza