Add Redis and TiKV kv stores #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the TiKV client doesn't support 32-bit as well. I'll update |
mihaimaruseac
approved these changes
Nov 15, 2023
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
jeffmendoza
force-pushed
the
kv-stores
branch
from
80e9fb7
to
6f25b6d
Compare
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
pxp928
approved these changes
Nov 15, 2023
nathannaveen
pushed a commit
to nathannaveen/guac
that referenced
this pull request
Nov 16, 2023
* Add Redis and TiKV kv stores Signed-off-by: Jeff Mendoza <jlm@jlm.name> * Only use TiKV on 64 bit Signed-off-by: Jeff Mendoza <jlm@jlm.name> * Also don't built tikv for darwin. Signed-off-by: Jeff Mendoza <jlm@jlm.name> --------- Signed-off-by: Jeff Mendoza <jlm@jlm.name> Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
PR Checklist
-sflag togit commit.make generatehas been runcollectsubprotobuf has been changed,make protohas been run