Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove check if pkgID has already been checked for recursive vuln query #1608

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Dec 28, 2023

Description of the PR

A quick fix to remove if !checkedIDs[pkgID] { from line 540 as we would want to show a path to transient dependencies that also have the dependency on the same vulnerable package (even if it was already checked).

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: pxp928 <parth.psu@gmail.com>
@kodiakhq kodiakhq bot merged commit ad75a95 into guacsec:main Dec 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants