Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dsse processor to not guess unpacked payload #1647

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

lumjjb
Copy link
Contributor

@lumjjb lumjjb commented Jan 19, 2024

Description of the PR

Fixes #1633 . The format of the DSSE payload should not be handled by the processor and it should leave the handler pipeline to handle it via the guesser. DSSE implementation should be agnostic and not introspect its payload.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkg/handler/processor/dsse/dsse_test.go Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit c3464f8 into main Jan 30, 2024
10 checks passed
@kodiakhq kodiakhq bot deleted the update-dsse-proc branch January 30, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] DocumentITE6Generic does not have a corresponding parser
3 participants