Get Next Actionable Critical Dependencies Part 1 #1705

nathannaveen · 2024-02-12T20:53:32Z

Description of the PR

The code gets all dependencies using hasSBOM
This code finds the number of dependents for each package by finding the number of packages that depends on each individual package
Also added a REST endpoint.
Design doc: https://docs.google.com/document/d/1892EPekBkHbOSV2iL_61HGV0uzJHsO205mEKkHIonZ0/edit?usp=sharing
Addresses the first part of [feature] What's the next actionable critical dependency? #1505. “Checking what the package with the highest number of IsDependency edges / or HasSBOM edges are”.

PR Checklist

All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
All new changes are covered by tests
If GraphQL schema is changed, make generate has been run
If collectsub protobuf has been changed, make proto has been run
All CI checks are passing (tests and formatting)
All dependent PRs have already been merged

nathannaveen · 2024-02-12T20:54:00Z

@mdeicas 👀

pxp928

Looks good, one nit

pkg/dependencies/dependents.go

lumjjb · 2024-02-25T18:28:36Z

@mdeicas , would you be able to help review this?

pkg/dependencies/dependents.go

pkg/dependencies/dependents_test.go

pkg/dependencies/dependents.go

mdeicas

Thanks for working on this @nathannaveen!! I added some comments on the code but also wanted to ask about the granularity of the dependency relationship at a higher level (see the comment on this).

pkg/guacrest/server/server.go

pkg/guacrest/openapi.yaml

pkg/dependencies/dependents.go

cmd/guacone/cmd/vulnerability.go

pkg/dependencies/dependents.go

pkg/dependencies/dependents_test.go

pkg/dependencies/dependents.go

pxp928 · 2024-04-03T23:54:09Z

@nathannaveen once PR #1807 merged, rebase and your tests should pass.

nathannaveen · 2024-04-05T14:40:00Z

@nathannaveen once PR #1807 merged, rebase and your tests should pass.

Thanks @pxp928!

pkg/dependencies/dependents.go

cmd/guacone/cmd/vulnerability.go

mdeicas

Thanks for making the changes @nathannaveen! A few more minor comments.

pkg/dependencies/dependents.go

pkg/guacrest/server/server.go

pkg/dependencies/dependents_test.go

nathannaveen · 2024-05-10T23:29:54Z

Everyone, thanks for your reviews!

This PR has been open for a pretty long time, so if there are any nits in the future, can we create an issue for them so that we can get this PR merged in?

mdeicas

Aside from these two comments, LGTM @nathannaveen!!

pkg/dependencies/dependents_test.go

pkg/dependencies/dependents.go

* Got all dependencies using `hasSBOM` * This finds the number of package that depends on each individual package * Packages with different versions are still the same package Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

nathannaveen requested a review from jeffmendoza as a code owner February 12, 2024 20:53

pull-request-size bot added the size/XL label Feb 12, 2024

nathannaveen force-pushed the nathan/nextActionableCriticalDep2 branch from b70ef5f to 7032600 Compare February 12, 2024 21:00

nathannaveen force-pushed the nathan/nextActionableCriticalDep2 branch 4 times, most recently from fd88f21 to a296ed7 Compare February 21, 2024 17:38

pxp928 approved these changes Feb 23, 2024

View reviewed changes

pkg/dependencies/dependents.go Outdated Show resolved Hide resolved

jeffmendoza reviewed Feb 28, 2024

View reviewed changes

mdeicas requested changes Feb 29, 2024

View reviewed changes

jeffmendoza reviewed Mar 1, 2024

View reviewed changes

cmd/guacone/cmd/vulnerability.go Outdated Show resolved Hide resolved

mdeicas requested changes Mar 1, 2024

View reviewed changes

pkg/dependencies/dependents.go Outdated Show resolved Hide resolved

pkg/dependencies/dependents.go Outdated Show resolved Hide resolved

pkg/dependencies/dependents_test.go Show resolved Hide resolved

pkg/dependencies/dependents_test.go Show resolved Hide resolved

nathannaveen force-pushed the nathan/nextActionableCriticalDep2 branch 5 times, most recently from 280628a to fb8911d Compare March 7, 2024 16:06

mdeicas reviewed Mar 7, 2024

View reviewed changes

pkg/dependencies/dependents.go Outdated Show resolved Hide resolved

mdeicas reviewed Mar 7, 2024

View reviewed changes

pkg/dependencies/dependents.go Outdated Show resolved Hide resolved

nathannaveen force-pushed the nathan/nextActionableCriticalDep2 branch 2 times, most recently from c47967d to af96d18 Compare April 2, 2024 15:09

nathannaveen requested review from mdeicas and jeffmendoza April 2, 2024 15:09

nathannaveen force-pushed the nathan/nextActionableCriticalDep2 branch 2 times, most recently from ac00d9a to 3211c93 Compare April 3, 2024 13:58

nathannaveen requested a review from mihaimaruseac April 3, 2024 14:17

nathannaveen force-pushed the nathan/nextActionableCriticalDep2 branch from 3211c93 to 13ca53e Compare April 5, 2024 14:39

lumjjb requested changes Apr 11, 2024

View reviewed changes

pkg/dependencies/dependents.go Outdated Show resolved Hide resolved

pkg/dependencies/dependents.go Show resolved Hide resolved

pkg/dependencies/dependents.go Show resolved Hide resolved

cmd/guacone/cmd/vulnerability.go Outdated Show resolved Hide resolved

nathannaveen force-pushed the nathan/nextActionableCriticalDep2 branch from 13ca53e to cf32140 Compare April 19, 2024 21:35

nathannaveen requested a review from lumjjb April 19, 2024 21:40

mdeicas reviewed Apr 23, 2024

View reviewed changes

mdeicas mentioned this pull request Apr 24, 2024

Add a client testing library #1864

Closed

4 tasks

mdeicas reviewed May 2, 2024

View reviewed changes

pkg/dependencies/dependents_test.go Outdated Show resolved Hide resolved

nathannaveen force-pushed the nathan/nextActionableCriticalDep2 branch from cf32140 to 1499be4 Compare May 10, 2024 23:24

pxp928 requested a review from mdeicas May 13, 2024 13:37

mdeicas approved these changes May 13, 2024

View reviewed changes

pkg/dependencies/dependents_test.go Outdated Show resolved Hide resolved

pkg/dependencies/dependents.go Outdated Show resolved Hide resolved

nathannaveen force-pushed the nathan/nextActionableCriticalDep2 branch from 1499be4 to c384f15 Compare May 16, 2024 17:59

nathannaveen added 9 commits May 16, 2024 13:03

Included a Rest Endpoint for the Next Actionable Critical Dependency

fa7c7fc

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

Fixed Integration Tests

1b61fc0

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

Updated based on code review

4bb20e1

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

Updated based on code reivew

4484284

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

Updated based on code review

3ed7c26

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

Updated based on code review

cc21652

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

Updated based on code review

fb328ae

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

Updated based on code review

539b7d6

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

nathannaveen force-pushed the nathan/nextActionableCriticalDep2 branch from c384f15 to 539b7d6 Compare May 16, 2024 18:03

lumjjb approved these changes May 23, 2024

View reviewed changes

kodiakhq bot merged commit 14cd291 into guacsec:main May 23, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get Next Actionable Critical Dependencies Part 1 #1705

Get Next Actionable Critical Dependencies Part 1 #1705

nathannaveen commented Feb 12, 2024 •

edited

Loading

nathannaveen commented Feb 12, 2024

pxp928 left a comment

lumjjb commented Feb 25, 2024

mdeicas left a comment

pxp928 commented Apr 3, 2024

nathannaveen commented Apr 5, 2024

mdeicas left a comment

nathannaveen commented May 10, 2024

mdeicas left a comment

Get Next Actionable Critical Dependencies Part 1 #1705

Get Next Actionable Critical Dependencies Part 1 #1705

Conversation

nathannaveen commented Feb 12, 2024 • edited Loading

Description of the PR

PR Checklist

nathannaveen commented Feb 12, 2024

pxp928 left a comment

Choose a reason for hiding this comment

lumjjb commented Feb 25, 2024

mdeicas left a comment

Choose a reason for hiding this comment

pxp928 commented Apr 3, 2024

nathannaveen commented Apr 5, 2024

mdeicas left a comment

Choose a reason for hiding this comment

nathannaveen commented May 10, 2024

mdeicas left a comment

Choose a reason for hiding this comment

nathannaveen commented Feb 12, 2024 •

edited

Loading