Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included a README for guacrest #1719

Merged
merged 1 commit into from Mar 27, 2024
Merged

Included a README for guacrest #1719

merged 1 commit into from Mar 27, 2024

Conversation

nathannaveen
Copy link
Contributor

@nathannaveen nathannaveen commented Feb 21, 2024 •
edited

Description of the PR

This includes a README for guacrest.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen
Included a README for guacrest
7b9ca16 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Copy link
Contributor Author

👀 @mdeicas

@pxp928 pxp928 requested a review from mdeicas March 1, 2024 17:59
@kodiakhq kodiakhq bot merged commit 638ba85 into guacsec:main Mar 27, 2024
8 checks passed
@nathannaveen nathannaveen deleted the nathan/AddRestReadme branch March 27, 2024 17:13
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request Apr 1, 2024
@nathannaveen @arorasoham9
Included a README for guacrest (guacsec#1719)
1e8fdfc 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request Apr 4, 2024
@nathannaveen @arorasoham9
Included a README for guacrest (guacsec#1719)
958766a 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@pxp928 pxp928 pxp928 approved these changes

@mdeicas mdeicas Awaiting requested review from mdeicas

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nathannaveen @jeffmendoza @pxp928