Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphQL schema to add documentRef field to all verbs #1834

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Apr 11, 2024

Description of the PR

Update graphQL schema to add documentRef field to all verbs.

Subsequent PRs will include update to the processor.Document, parsers, and backend databases.

Updates the graphQL schema based on issue: #1833

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: pxp928 <parth.psu@gmail.com>
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo the discussion on String vs String!

Signed-off-by: pxp928 <parth.psu@gmail.com>
@kodiakhq kodiakhq bot merged commit a0a0a82 into guacsec:main Apr 11, 2024
8 checks passed
@pxp928 pxp928 deleted the graphql-add-doc-ref branch April 11, 2024 22:17
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request May 17, 2024
…1834)

* add documentRef field to all verbs

Signed-off-by: pxp928 <parth.psu@gmail.com>

* make documentRef optional

Signed-off-by: pxp928 <parth.psu@gmail.com>

---------

Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: Soham Arora <arorasoham9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants