Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with supported backends. #1873

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

jeffmendoza
Copy link
Collaborator

Description of the PR

Clarify and highlight the supported backends.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@jeffmendoza
Copy link
Collaborator Author

cc @funnelfiasco for review.

Copy link
Contributor

@funnelfiasco funnelfiasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally, although I think my suggested wording tweak in the ent entry is worth adopting.

I have some proto-thoughts about how we might move backends (and other feature additions) through the lifecycle, but they're not nearly well-formed enough to block this PR. Something to figure out with the community over time.

README.md Outdated Show resolved Hide resolved
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
@jeffmendoza
Copy link
Collaborator Author

I have some proto-thoughts about how we might move backends (and other feature additions) through the lifecycle, but they're not nearly well-formed enough to block this PR. Something to figure out with the community over time.

Looking forward to it.

Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@kodiakhq kodiakhq bot merged commit c2477fa into guacsec:main Apr 30, 2024
8 checks passed
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request May 17, 2024
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
Signed-off-by: Soham Arora <arorasoham9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants