Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved cdx parsing #1903

Merged
merged 5 commits into from
May 29, 2024
Merged

Improved cdx parsing #1903

merged 5 commits into from
May 29, 2024

Conversation

Yaxhveer
Copy link
Contributor

Description of the PR

Improved cdx parsing and updated the test accordingly.
Fixes: #1884

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • All CI checks are passing (tests and formatting)

@pxp928 pxp928 requested review from lumjjb and pxp928 May 10, 2024 12:21
pxp928
pxp928 reviewed May 10, 2024
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Yaxhveer for working on this. I apologize for the mistake I made in my explanation. Added some comments to correct that. Otherwise you are on the right track! Thank You.

internal/testing/testdata/testdata.go Outdated Show resolved Hide resolved
internal/testing/testdata/testdata.go Show resolved Hide resolved
internal/testing/testdata/testdata.go Show resolved Hide resolved
@Yaxhveer
Copy link
Contributor Author

Hey @pxp928, I have updated the PR.

pxp928
pxp928 previously approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank You!

@pxp928 pxp928 added the needs-review Needs writer LGTM label May 13, 2024
@pxp928 pxp928 dismissed their stale review May 15, 2024 01:39

after further testing the mapping is wrong.

@pxp928
Copy link
Collaborator

pxp928 commented May 15, 2024

@Yaxhveer we will have to rebase this PR. Could you please do that?

Yaxhveer and others added 4 commits May 15, 2024 19:47
@Yaxhveer
improved cdx parsing
4aee40c 
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
@Yaxhveer
corrected the implementation
de6280d 
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
@Yaxhveer
updated changes
34349c4 
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
@pxp928 @Yaxhveer
if not part of dependencies, add to top level package
2d6b221 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 15, 2024
@Yaxhveer
corrected the cyclonedx parser
19fe0e5 
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
@pull-request-size pull-request-size bot added size/M and removed size/L labels May 15, 2024
pxp928
pxp928 approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You! LGTM

lumjjb
lumjjb approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @Yaxhveer

@kodiakhq kodiakhq bot merged commit 8b702d0 into guacsec:main May 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxp928 pxp928 pxp928 approved these changes

@lumjjb lumjjb lumjjb approved these changes

Assignees
No one assigned
Labels
needs-review Needs writer LGTM size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Improve CDX parsing
3 participants
@Yaxhveer @pxp928 @lumjjb