Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slsa parser to remove deprecated structs #1988

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

Yaxhveer
Copy link
Contributor

@Yaxhveer Yaxhveer commented Jun 28, 2024

Description of the PR

Fixes #1987

Updated the slsa parser by removing deprecated structs of in-toto-golang with the in-toto attestation repo. Added nil pointer checks wherever needed.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Yaxhveer! Added a few comments but overall looks good.

pkg/ingestor/parser/slsa/parser_slsa.go Outdated Show resolved Hide resolved
pkg/ingestor/parser/slsa/parser_slsa.go Outdated Show resolved Hide resolved
pkg/ingestor/parser/slsa/parser_slsa.go Outdated Show resolved Hide resolved
pkg/ingestor/parser/slsa/parser_slsa.go Outdated Show resolved Hide resolved
pkg/ingestor/parser/slsa/parser_slsa.go Outdated Show resolved Hide resolved
pkg/ingestor/parser/slsa/parser_slsa.go Outdated Show resolved Hide resolved
pkg/ingestor/parser/slsa/parser_slsa.go Outdated Show resolved Hide resolved
pkg/ingestor/parser/slsa/parser_slsa.go Outdated Show resolved Hide resolved
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
@Yaxhveer Yaxhveer requested a review from pxp928 July 1, 2024 14:43
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
@Yaxhveer Yaxhveer requested a review from pxp928 July 2, 2024 08:38
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work

@kodiakhq kodiakhq bot merged commit 2d87d8d into guacsec:main Jul 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Change from using in-toto-golang for SLSA to in-toto attestations repo
3 participants