Update guard compat #181
Merged
Update guard compat #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using a Guard plugin in a Rake task without guard was a bit of a surprise. I didn't implement the colored output in Cli mode - mostly because I didn't have a way to decide if it should be on or off. |
|
@e2 Sorry for the delay on this. I'd somehow had thought that that you'd merged it already. |
|
No problem at all. I didn't merge it in case you'd notice something out of place - besides, I didn't test it extensively, so I wasn't confident in merging without a review from your side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this guard-jasmine should be "protected" from upcoming major Guard refactoring.
Let me know if you have any issues/requests with this PR or with Guard or Guard::Compat.
I'm pretty much done with Guard::Compat and updating all the plugins, so if there's anything useful missing from the Compat API, let me know (open an issue in Guard::Compat).