Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes when stopping Listen too soon #394

Merged
merged 2 commits into from
May 18, 2016
Merged

Fix crashes when stopping Listen too soon #394

merged 2 commits into from
May 18, 2016

Conversation

e2
Copy link
Contributor

@e2 e2 commented May 17, 2016

  • prevent crash when stopping uninitialized listener
  • prevent crash when stopping uninitialized adapter

houndci-bot
houndci-bot reviewed May 17, 2016
View reviewed changes
spec/lib/listen/adapter/linux_spec.rb
it 'stops the worker' do
expect(fake_worker).to receive(:close)
subject.stop
context "when not even initialized" do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.

@e2 e2 force-pushed the fix_crash_when_uninitialized branch from 59b0c9f to 2c78999 Compare May 17, 2016 23:11
@coveralls
Copy link

coveralls commented May 17, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-7.2%) to 90.572% when pulling 59b0c9f on fix_crash_when_uninitialized into 8f5a3f0 on master.

@coveralls
Copy link

coveralls commented May 17, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 98.076% when pulling 2c78999 on fix_crash_when_uninitialized into 8f5a3f0 on master.

@e2 e2 merged commit 8c7aa69 into master May 18, 2016
@e2 e2 deleted the fix_crash_when_uninitialized branch May 18, 2016 01:06
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e2 @coveralls @houndci-bot