issue #487: unify Thread.new #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 20, 2020
houndci-bot
reviewed
Sep 20, 2020
ColinDKelley
force-pushed
the
issue-487/unify-thread-new
branch
from
dacd64e
to
17b4d32
Compare
houndci-bot
reviewed
Sep 20, 2020
ColinDKelley
changed the title
|
@jonathanhefner Can you please also review? |
ColinDKelley
force-pushed
the
issue-487/unify-thread-new
branch
from
1a57218
to
746abe2
Compare
houndci-bot
reviewed
Oct 14, 2020
ColinDKelley
force-pushed
the
issue-487/unify-thread-new
branch
from
746abe2
to
b8dfb0c
Compare
|
I just rebased to master. |
ioquatix
reviewed
Oct 30, 2020
ioquatix
reviewed
Oct 30, 2020
ioquatix
reviewed
Oct 30, 2020
ioquatix
reviewed
Oct 30, 2020
ioquatix
reviewed
Oct 30, 2020
ioquatix
approved these changes
Oct 30, 2020
|
Thanks for the review, @ioquatix and @jonathanhefner. I believe all the comments are addressed, but don't hesitate to @-mention me if I missed anything, or more discussion would be helpful. Rebasing + merging into master now. |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #487:
Listen::Threadmodule.Thread#name =property to assist with debugging in the surrounding process.rescueall exceptions inListen::Threadand log them, including complete call stack (caller + exception backtrace) and showcausedetail if any.Thread#join,Thread.kill.