Compute the SHA1 sum only for regular files #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disables checksumming for all char/block devices, FIFOs, sockets that may have been shown as having changed, and only checksums regular ones. This allows compatibility between Guard and Zeus (and potentially, some weird ssh ControlSocket games).
|
Looks great, yeah at least a OS X / Linux (travis-ci) spec would be nice. Thanks! |
This creates a UNIX domain socket (not compatible with Windows) and "modifies" it - a correctly working Listen should not attempt to SHA1 that file (as it confuses servers).
|
This should do it - the test case fails without the commit fixing the problem above and succeeds with it. I've made it conditional on not running on windows (and it tests for the case of unix local sockets). Hope that's ok! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current checksumming code in directory_record.rb's
content_modified?method will attempt to open & compute the checksum of any directory entry that comes up as changed. On OS X at least, that will also try and compute the checksum of local sockets and FIFOs, which not only fails but also confuses any program on the other side of that dirent.This change checks for the regular-fileness of a changed directory entry and simply doesn't count those as having had their content changed if they're not a regular file.
I am pretty sure that this PR as it is doesn't pass muster (there's no test for it), but would like to submit it for discussion anyway. What would be the ideal way to test this? Should I make it a platform-specific test for Darwin (where I can reproduce the issue)?