This repository has been archived by the owner on Apr 17, 2024. It is now read-only.
Preview atoms #61
Merged
Preview atoms #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2019 17:08
ajwl
reviewed
Feb 15, 2019
| } | ||
|
|
||
| val capiService: HttpRoutes[IO] = HttpRoutes[IO] { | ||
| case GET -> Root :? AtomTypeMatcher(atomType) +& AtomIdMatcher(atomId) => |
There was a problem hiding this comment.
Hmm I find Scala syntax like this very hard to understand. Perhaps you can talk me through this on Monday?
There was a problem hiding this comment.
Yes of course
added 5 commits
February 15, 2019 11:26
utils/src/main/scala/com.gu.contentatom.renderer/utils/CapiService.scala
Outdated
Show resolved
Hide resolved
utils/src/main/scala/com.gu.contentatom.renderer/utils/CapiService.scala
Outdated
Show resolved
Hide resolved
utils/src/main/scala/com.gu.contentatom.renderer/utils/CapiService.scala
Outdated
Show resolved
Hide resolved
|
@JustinPinner 👍 I've gone through your feedback. |
JustinPinner
approved these changes
Feb 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very first shot at a way to preview atoms quickly to speed up development.
Todo