Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use changesets to automate releases #2071

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Use changesets to automate releases #2071

merged 4 commits into from
Oct 30, 2023

Conversation

joecowton1
Copy link
Contributor

@joecowton1 joecowton1 commented Oct 24, 2023

What does this change?

This PR replaces semantic-release with Changesets - this is the Guardian's recommended approach to automated NPM releases.

How to test

Create a patch release by running npm run release and following the instructions.

When this PR is merged it the Changesets bot (once installed) will create a subsequent release PR. Once this second PR is merged the release will be complete.

@joecowton1 joecowton1 requested a review from a team as a code owner October 24, 2023 15:11
@joecowton1 joecowton1 marked this pull request as draft October 24, 2023 15:12
@joecowton1 joecowton1 marked this pull request as ready for review October 24, 2023 15:26
@joecowton1 joecowton1 marked this pull request as draft October 24, 2023 15:35
@joecowton1 joecowton1 force-pushed the jc/test-changeset branch 2 times, most recently from fdf78a8 to 33b0376 Compare October 24, 2023 16:34
@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

⚠️ No Changeset found

Latest commit: b62d266

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joecowton1 joecowton1 marked this pull request as ready for review October 26, 2023 14:40
@joecowton1 joecowton1 changed the title Test changesets Use changesets to automate releases Oct 26, 2023
Copy link
Member

@akash1810 akash1810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks for doing this! Added a couple of minor questions.

#2080 is waiting to be merged, maybe that can be used to test the new process?

package.json Show resolved Hide resolved
.changeset/config.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
@joecowton1
Copy link
Contributor Author

joecowton1 commented Oct 30, 2023

Wonderful, thanks for doing this! Added a couple of minor questions.

#2080 is waiting to be merged, maybe that can be used to test the new process?

Yeah definitely, I think if this all works (which it should) we'd just need to add a changeset to the other pr using the changesets cli tool and it would make a great test.

@joecowton1 joecowton1 merged commit 1c6493b into main Oct 30, 2023
2 checks passed
@joecowton1 joecowton1 deleted the jc/test-changeset branch October 30, 2023 09:01
@akash1810 akash1810 mentioned this pull request Oct 30, 2023
2 tasks
akash1810 added a commit that referenced this pull request May 17, 2024
Since the migration to changesets from semantic-release in #2071,
the requirement to use convential commits is removed.

Therefore we can drop a dependency.
akash1810 added a commit that referenced this pull request May 17, 2024
akash1810 added a commit that referenced this pull request May 28, 2024
Since the migration to changesets from semantic-release in #2071,
the requirement to use convential commits is removed.

Therefore we can drop a dependency.
akash1810 added a commit that referenced this pull request May 28, 2024
akash1810 added a commit that referenced this pull request Jun 11, 2024
Since the migration to changesets from semantic-release in #2071,
the requirement to use convential commits is removed.

Therefore we can drop a dependency.
akash1810 added a commit that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants