Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move src/lib/* to src #1152

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Move src/lib/* to src #1152

merged 4 commits into from
Nov 21, 2023

Conversation

arelra
Copy link
Member

@arelra arelra commented Nov 21, 2023

What does this change?

We currently have the following directory structure:

- src
  - core (lib type modules for export)
  - lib (containing most of the codebase)
    - dfp
    - messenger
    - ...

This PR updates the structure to the following:

- src
  - core (lib type modules for export)
  - dfp
  - messenger
  - ...

I've checked the build output and it is exactly the same.

Why?

The current structure is a hangover from:

  1. the migration of the commercial code from frontend to this repo commercial
  2. the merging of commercial-core into commercial

Having all directories flattened under src/ is more standard.

The directory structure however is still largely carried over from Frontend which we can improve but this is the first step.

@arelra arelra requested a review from a team November 21, 2023 09:58
Copy link

changeset-bot bot commented Nov 21, 2023

⚠️ No Changeset found

Latest commit: 912f3e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

arelra and others added 3 commits November 21, 2023 16:13
Co-authored-by: Jake Lee Kennedy <jake.kennedy@guardian.co.uk>
Copy link
Contributor

@chrislomaxjones chrislomaxjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement! Can't say I reviewed every file, but if all the checks have passed...

@arelra arelra merged commit 8cf187d into main Nov 21, 2023
10 checks passed
@arelra arelra deleted the ravi/rearrange-src-1 branch November 21, 2023 17:14
@arelra arelra changed the title Move src/lib/* to src Move src/lib/* to src Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants