Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commercial Q4 mega test #1318

Merged
merged 12 commits into from
Apr 3, 2024
Merged

Commercial Q4 mega test #1318

merged 12 commits into from
Apr 3, 2024

Conversation

domlander
Copy link
Contributor

@domlander domlander commented Mar 25, 2024

What does this change?

Add the following changes we have made over the last quarter to a mega test to asses the overall impact of all the changes.

Included Changes

This will also remove the section ad density test and make it live for everyone not in the control group

Why?

Most of these have been released, so for this test we are holding back/removing the changes for a percentage of users in the control group.

Copy link

changeset-bot bot commented Mar 25, 2024

🦋 Changeset detected

Latest commit: 2b8743a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/commercial Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@deedeeh deedeeh added the [beta] @guardian/commercial Add this label to publish an @guardian/commercial beta npm release from a PR label Mar 28, 2024
Copy link
Contributor

🚀 0.0.0-beta-20240328171413 published to npm as a beta release

@Jakeii Jakeii marked this pull request as ready for review April 2, 2024 16:50
@Jakeii Jakeii requested a review from a team as a code owner April 2, 2024 16:50
Copy link
Contributor

@chrislomaxjones chrislomaxjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Jakeii Jakeii merged commit 9831737 into main Apr 3, 2024
10 checks passed
@Jakeii Jakeii deleted the doml/ab-mega-test branch April 3, 2024 13:03
@emma-imber emma-imber mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[beta] @guardian/commercial Add this label to publish an @guardian/commercial beta npm release from a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants