Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @guardian/support-dotcom-components #1346

Closed
wants to merge 1 commit into from

Conversation

mxdvl
Copy link
Contributor

@mxdvl mxdvl commented Apr 22, 2024

What does this change?

Bumps @guardian/support-dotcom-components to v2.0.1.
This is a major change as per our recommendations, and consumers should
ensure that they provide a compatible version of the package.

Why?

The latest is v2.0.1 and this is what is used in dotcom-rendering, so it addresses a mismatched peer dependency.

The latest is v2.0.1

BREAKING CHANGE! as this touches peer dependencies
@mxdvl mxdvl requested a review from a team as a code owner April 22, 2024 11:20
Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: 258cfce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/commercial Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mxdvl mxdvl added the dependencies Pull requests that update a dependency file label Apr 22, 2024
@Jakeii
Copy link
Member

Jakeii commented Apr 22, 2024

Can we drop this as a dependency? It's not used here and not a peer of a dep as far as I can see?

@mxdvl mxdvl closed this Apr 22, 2024
@mxdvl mxdvl deleted the mxdvl/dependencies/bump-guardian-packages branch April 22, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants